Sorted based on the number of comments given to others' PRs, but also showing comments on own PRs and other comments given. Updated weekly.
[This page was last updated on Mar 25 2021]
@Impala36
(13 comments)1 (commented on others PR)
Same as the comment above.
2 (commented on others PR)
Perhaps the second NRIC field should be removed?
3 (commented on others PR)
Line 190: Perhaps the NRIC field could also be shifted to after Name?
4 (commented on others PR)
Perhaps S1111112B could be replaced with S1234567B so that it's easier to check the correct format?
5 (commented on others PR)
S12345678A has 8 numbers instead of the required 7.
6 (commented on others PR)
These extra newlines should be removed.
7 (commented on others PR)
There are two date fields.
8 (commented on others PR)
Same case as above.
9 (commented on others PR)
The example add dat is not in the second position.
10 (commented on others PR)
Edit and Find date field is not in the second position.
11 (commented on others PR)
There might be an issue with this.
Previously it was getName AND (getNric OR getPhone).
Now it is getName AND getNric AND getPhone AND getEmail.
12 (commented on others PR)
This should also check for leap years, it would be 29 days instead.
13 (commented on others PR)
Line 43 and 44 are the same.
14 (other comment)
I have added the remark command, field and tests in this commit.
15 (other comment)
Pushing from wrong branch.
16 (other comment)
Format: followup INDEX NUMBER_OF_DAYS
17 (other comment)
Show exclamation icon when person to be called is today
Show number of days set for the call interval
@e0260222
(4 comments)1 (commented on others PR)
Perhaps this should be list all employees in Employee Tracker
instead to make it more consistent with our naming conventions?
2 (commented on others PR)
Perhaps Employee Tracker
is more consistent with our naming convention than address book
?
3 (commented on others PR)
Perhaps [n/NAME]
should be removed?
4 (commented on others PR)
Perhaps [r/ROLE]
should be removed?
5 (other comment)
Does not add value to both users and developers who are maintaining the code
@Yiheng0410
(1 comments)1 (commented on others PR)
ok
2 (commented on own PR)
done
3 (commented on own PR)
done
4 (commented on own PR)
removed the duplicated one
5 (commented on own PR)
corrected
6 (commented on own PR)
done
@JanuariusJang
(0 comments)1 (other comment)
Finished Developers guide
@Chilaiping
(0 comments)1 (other comment)
For tutorial learning
@skyventus
(0 comments)1 (other comment)
Done
2 (other comment)
Thanks!
3 (other comment)
Good
@daiweinus
(0 comments)1 (commented on own PR)
done
2 (other comment)
close #4, close #8, close #13
3 (other comment)
The PRs created for tutorials need not be merged.
@dgc5213
(0 comments)1 (other comment)
@e0260222 Hi Weizhong Please help to add Milestone and merge it. thanks
2 (other comment)
Please help merge. thanks @e0260222
3 (other comment)
@e0260222 Hi Weizhong, Please help to add milestone and merge it. thanks
4 (other comment)
@e0260222 Please help merge it. thanks
5 (other comment)
Hi @e0260222 , Please help merge it . thanks
@tototto
(0 comments)1 (other comment)
no need to create PR to Team Repo for this tutorial-removing-field
2 (other comment)
resolved merge conflict that was blocking CI
3 (other comment)
invalid user story
4 (other comment)
unable to replicate after merging multiple PRs was done.
closing issue.
@e0261618
(0 comments)1 (other comment)
closing due to incorrect branch
@timmyly7
(0 comments)1 (other comment)
Merge code, add new feature for appointment
2 (other comment)
View appointment function is added to the app
3 (other comment)
Now can view appointment base on seach of the patient name
@adi-kd0021
(0 comments)1 (other comment)
Reviewed. All good so far.
2 (other comment)
Page is updated
3 (other comment)
Page is updated
4 (other comment)
View Patient data function has been updated
5 (other comment)
Functionality exists
6 (other comment)
Functionality exists
@binbinhui
(0 comments)1 (other comment)
Done
2 (other comment)
Done
3 (other comment)
task done.
4 (other comment)
Done
5 (other comment)
Done
6 (other comment)
Done
7 (other comment)
verified.
@linqing42
(0 comments)1 (commented on own PR)
okay
2 (commented on own PR)
noted
3 (commented on own PR)
okay. i will update it and the IC code change to NRIC and the space between IC and phone
4 (other comment)
but cannot show in Address App
5 (other comment)
pls, ignore the commits as it is wrong reference to this issue. it supposes be issue add NRIC.
6 (other comment)
solve the issue regarding the show in Address app.
7 (other comment)
updated
8 (other comment)
done
9 (other comment)
done
10 (other comment)
updated
11 (other comment)
done
12 (other comment)
pls help me review regarding update UG with NRIC
13 (other comment)
Hi, I help you to close the issue
14 (other comment)
Hi, I help you to close the issue
15 (other comment)
UML(addCommandSequence diagram)
@ZhengShijieNUS
(0 comments)1 (other comment)
Close due to more updates
2 (other comment)
Change to: